[PATCH] contribution: code review extension

[Boris Glimcher]

Thanks for the reply.

I've added wiki page here :
http://mercurial.selenic.com/wiki/CodeReviewExtension



--------------------------------------------------------------------------------

-----Original Message----- 
> From: Dirkjan Ochtman <dirkjan at ochtman.nl>
> Sent: Mon, 7 Sep 2009 22:32:41 +0200
> To: Boris Glimcher <glimchb at gmail.com>
> CC: mercurial at selenic.com
> Subject: Re: [PATCH] contribution: code review extension

> On Mon, Sep 7, 2009 at 18:54, Boris Glimcher<glimchb at gmail.com> wrote:
> > # HG changeset patch
> > # User Boris Glimcher
> > # Date 1252340875 -10800
> > # Node ID 95aac6072859a4db5d8be521afdafe8972c53be9
> > # Parent  37042e8b3b342b2e380d8be3e3f7692584c92d33
> > contribution: code review extension
> 
> Thanks for writing and submitting this extension! Unfortunately, we
> probably won't accept your patch at this time.
> 
> First of all, it's not clear to me what code review software or
> service this is supposed to plug into. This means you're notably short
> on documentation.
> 
> Second of all, we usually don't put extensions into hgext unless
> they've been demonstrated to be useful to large part of our userbase.
> 
> Please put your extension up in a repository somewhere (on
> bitbucket.org, for example), and create a page on the wiki so that
> people may find it. I suggest you reference that page from the
> UsingExtensions page, which has a big list of extensions (among which
> some other code review extensions you might find interesting).
> 
> Cheers,
> 
> Dirkjan


--------------------------------------------------------------------------------