Announcement: mercurial_keyring

Marcin Kasperski Marcin.Kasperski at mekk.waw.pl
Sat Nov 21 06:29:53 CST 2009


> I had a quick look. You have some tabs instead of spaces

Fixed.

> and lines longer than 80 char (that was for the coding style).

Fixed except 3 cases where I find fixing it very unnatural (error
messages for Abort and url example in docstring)

> You should probably ask the user before storing the password, at least
> I'd prefer that.

I'd prefer not to ;-)

More seriously: I dislike being prompted many times for obvious
things. By installing and enabling the extension the user already
acknowledged that he (or she) wants the passwords saved.

Still, if more people share your attitude, I will consider
implementing an option for this.

Thank you for your remarks.


More information about the Mercurial mailing list