Announcement: mercurial_keyring

[Benoit Boissinot]

On Sat, Nov 21, 2009 at 01:29:53PM +0100, Marcin Kasperski wrote:
> > I had a quick look. You have some tabs instead of spaces
> 
> Fixed.
> 
> > and lines longer than 80 char (that was for the coding style).
> 
> Fixed except 3 cases where I find fixing it very unnatural (error
> messages for Abort and url example in docstring)
> 
> > You should probably ask the user before storing the password, at least
> > I'd prefer that.
> 
> I'd prefer not to ;-)
> 
> More seriously: I dislike being prompted many times for obvious
> things. By installing and enabling the extension the user already
> acknowledged that he (or she) wants the passwords saved.

It is only once per url. That isn't many times (given if the user
refuses you don't ask anymore afterwards, like firefox).

regards,

Benoit

-- 
:wq