Announcement: mercurial_keyring

[Benoit Boissinot]

On Fri, Nov 20, 2009 at 11:09:17PM +0100, Marcin Kasperski wrote:
> 
> I published first version of mercurial_keyring extension:
> 
>     http://bitbucket.org/Mekk/mercurial_keyring/
> 
> For documentation refer to
> 
>     http://bitbucket.org/Mekk/mercurial_keyring/src/tip/mercurial_keyring.py
> 
> I'd be grateful if somebody could review my code. It's rather short ;-)

I had a quick look. You have some tabs instead of spaces and lines
longer than 80 char (that was for the coding style).

You should probably ask the user before storing the password, at least
I'd prefer that.

regards,

Benoit

-- 
:wq