Ann: attic extension - just about ready for users

[Bill Barry]

Paul Moore wrote:
> 2009/1/27 Martin Geisler <mg at daimi.au.dk>:
>   
>> It says
>>
>>  Shelve (the interactive shelving extension) is almost entirely a
>>  subset of attic. In fact attic's hg shelve --interactive is calling 3
>>  methods directly pulled from the hgshelve extension source code.
>>
>> I have not looked at the code for either extension, but would it not be
>> a good idea to combine then? I mean, take any left-over features from
>> shelve and put them in attic and call this shelve?
>>
>> That would less code to maintain and less confusion for the users.
>>     
>
> It sounds like a plausible suggestion. And given that both attic and
> shelve build on record (in some sense), it may also be worth merging
> that in. Essentially, I'd like to see one extension (presumably attic,
> as it's the most extensive) replace all 3 existing ones, and be
> distributed with Mercurial (as record is now).
>   
Attic uses record for the dirty work. If anything, record should be 
refactored to an internal "interactivepatchfilter.py" and then the 
record commands (the dorecord method) be rebuilt to use it.

A key difference between attic and shelve is that attic requires record 
in order to do interactive stuff. Otherwise it is the same code (I 
grabbed 3 methods from shelve, the rest was mostly duplication of record).
> But it's a bit early yet for that - let attic mature a bit first, I guess.
>   
I'd love to see attic distributed with Mercurial. Probably not for this 
upcoming release, but the next one sure.
Some things that I think should be before attic is distributed with hg:
1. a bit more stabilization (I think we are just about there after a 
couple of days hanging out on irc)
2. some usage time (a couple of weeks or so)
3. input from mpm

Other things that should happen around/before the time attic gets pulled in:
1. refactoring some of the patch utility methods out of mq
2. bash shell script tests (the current ones are all .bat files combined 
with a nifty runtests.bat script that I wrote; btw please feel free to 
use this for any Windows CLI testing you ever decide you want to do, it 
only requires diff outside of normal dos commands).
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://selenic.com/pipermail/mercurial/attachments/20090127/cb221ce2/attachment.htm