Ann: attic extension - just about ready for users

[Bill Barry]

Martin Geisler wrote:
> It says
>
>   Shelve (the interactive shelving extension) is almost entirely a
>   subset of attic. In fact attic's hg shelve --interactive is calling 3
>   methods directly pulled from the hgshelve extension source code.
>
> I have not looked at the code for either extension, but would it not be
> a good idea to combine then? I mean, take any left-over features from
> shelve and put them in attic and call this shelve?
>
> That would less code to maintain and less confusion for the users.
At first I hadn't planned on doing any interactive features. Now that 
they are there it does make some sense. Being that I've already taken 
the parts of shelve that supply this (3 methods and call the rest from 
record), I see no reason to continue with a merge (the only purpose for 
it would be to enable usage of the interactive shelve in attic without 
enabling record). A better path I think would be to refactor the record 
extension so that the functionality for interactive patch filtering can 
be used without enabling the extension.

If the maintainer(s) of shelve have no objections we can discuss 
removing that extension and putting their names in the header file for 
attic (something I planned to do anyways; it was their contributions 
after all even if I might have taken without asking) and perhaps 
renaming attic.