A patch for a bug on date formats with '>' or '<' accompanied by space characters
Justin Peng
justin.peng.sw at gmail.com
Wed Apr 1 11:14:27 CDT 2009
2009/4/1 Matt Mackall <mpm at selenic.com>:
>
> Looks good. Please fold your test into the existing test-parse-dates.
>
Hi, mpm. I have finished it with a smaller patch. Please check it. Thanks!
Best Regards
--
Justin Peng
# HG changeset patch
# User Justin Peng <justin.peng.sw at gmail.com>
# Date 1238602260 25200
# Node ID e5626e38da5f47f119d3357f30febdc5a978bb9f
# Parent b2c18c7956221df0f961ac697a01effa1233978f
Correct a bug on date formats with '>' or '<' accompanied by space characters.
diff -r b2c18c795622 -r e5626e38da5f mercurial/util.py
--- a/mercurial/util.py Fri Mar 20 18:55:20 2009 -0500
+++ b/mercurial/util.py Wed Apr 01 09:11:00 2009 -0700
@@ -1838,6 +1838,7 @@
d["d"] = "28"
return parsedate(date, extendeddateformats, d)[0]
+ date = date.strip()
if date[0] == "<":
when = upper(date[1:])
return lambda x: x <= when
diff -r b2c18c795622 -r e5626e38da5f tests/test-parse-date
--- a/tests/test-parse-date Fri Mar 20 18:55:20 2009 -0500
+++ b/tests/test-parse-date Wed Apr 01 09:11:00 2009 -0700
@@ -43,3 +43,41 @@
hg debugdate "1000000000 16200" # -0430
hg debugdate "Sat Sep 08 21:16:40 2001 +0430"
hg debugdate "Sat Sep 08 21:16:40 2001 -0430"
+
+#Test date formats with '>' or '<' accompanied by space characters
+hg log -d '>' --template '{date|date}\n'
+hg log -d '<' hg log -d '>' --template '{date|date}\n'
+
+hg log -d ' >' --template '{date|date}\n'
+hg log -d ' <' --template '{date|date}\n'
+
+hg log -d '> ' --template '{date|date}\n'
+hg log -d '< ' --template '{date|date}\n'
+
+hg log -d ' > ' --template '{date|date}\n'
+hg log -d ' < ' --template '{date|date}\n'
+
+
+hg log -d '>02/01' --template '{date|date}\n'
+hg log -d '<02/01' --template '{date|date}\n'
+
+hg log -d ' >02/01' --template '{date|date}\n'
+hg log -d ' <02/01' --template '{date|date}\n'
+
+hg log -d '> 02/01' --template '{date|date}\n'
+hg log -d '< 02/01' --template '{date|date}\n'
+
+hg log -d ' > 02/01' --template '{date|date}\n'
+hg log -d ' < 02/01' --template '{date|date}\n'
+
+hg log -d '>02/01 ' --template '{date|date}\n'
+hg log -d '<02/01 ' --template '{date|date}\n'
+
+hg log -d ' >02/01 ' --template '{date|date}\n'
+hg log -d ' <02/01 ' --template '{date|date}\n'
+
+hg log -d '> 02/01 ' --template '{date|date}\n'
+hg log -d '< 02/01 ' --template '{date|date}\n'
+
+hg log -d ' > 02/01 ' --template '{date|date}\n'
+hg log -d ' < 02/01 ' --template '{date|date}\n'
\ No newline at end of file
diff -r b2c18c795622 -r e5626e38da5f tests/test-parse-date.out
--- a/tests/test-parse-date.out Fri Mar 20 18:55:20 2009 -0500
+++ b/tests/test-parse-date.out Wed Apr 01 09:11:00 2009 -0700
@@ -34,3 +34,111 @@
standard: Sat Sep 08 21:16:40 2001 +0430
internal: 1000000000 16200
standard: Sat Sep 08 21:16:40 2001 -0430
+Sun Jan 15 13:30:00 2006 +0500
+Sun Jan 15 13:30:00 2006 -0800
+Sat Jul 15 13:30:00 2006 +0500
+Sat Jul 15 13:30:00 2006 -0700
+Sun Jun 11 00:26:40 2006 -0400
+Sat Apr 15 13:30:00 2006 +0200
+Sat Apr 15 13:30:00 2006 +0000
+Wed Feb 01 13:00:30 2006 -0500
+Wed Feb 01 13:00:30 2006 +0000
+Sun Jan 15 13:30:00 2006 +0500
+Sun Jan 15 13:30:00 2006 -0800
+Sat Jul 15 13:30:00 2006 +0500
+Sat Jul 15 13:30:00 2006 -0700
+Sun Jun 11 00:26:40 2006 -0400
+Sat Apr 15 13:30:00 2006 +0200
+Sat Apr 15 13:30:00 2006 +0000
+Wed Feb 01 13:00:30 2006 -0500
+Wed Feb 01 13:00:30 2006 +0000
+Sun Jan 15 13:30:00 2006 +0500
+Sun Jan 15 13:30:00 2006 -0800
+Sat Jul 15 13:30:00 2006 +0500
+Sat Jul 15 13:30:00 2006 -0700
+Sun Jun 11 00:26:40 2006 -0400
+Sat Apr 15 13:30:00 2006 +0200
+Sat Apr 15 13:30:00 2006 +0000
+Wed Feb 01 13:00:30 2006 -0500
+Wed Feb 01 13:00:30 2006 +0000
+Sun Jan 15 13:30:00 2006 +0500
+Sun Jan 15 13:30:00 2006 -0800
+Sat Jul 15 13:30:00 2006 +0500
+Sat Jul 15 13:30:00 2006 -0700
+Sun Jun 11 00:26:40 2006 -0400
+Sat Apr 15 13:30:00 2006 +0200
+Sat Apr 15 13:30:00 2006 +0000
+Wed Feb 01 13:00:30 2006 -0500
+Wed Feb 01 13:00:30 2006 +0000
+Sun Jan 15 13:30:00 2006 +0500
+Sun Jan 15 13:30:00 2006 -0800
+Sat Jul 15 13:30:00 2006 +0500
+Sat Jul 15 13:30:00 2006 -0700
+Sun Jun 11 00:26:40 2006 -0400
+Sat Apr 15 13:30:00 2006 +0200
+Sat Apr 15 13:30:00 2006 +0000
+Wed Feb 01 13:00:30 2006 -0500
+Wed Feb 01 13:00:30 2006 +0000
+Sun Jan 15 13:30:00 2006 +0500
+Sun Jan 15 13:30:00 2006 -0800
+Sat Jul 15 13:30:00 2006 +0500
+Sat Jul 15 13:30:00 2006 -0700
+Sun Jun 11 00:26:40 2006 -0400
+Sat Apr 15 13:30:00 2006 +0200
+Sat Apr 15 13:30:00 2006 +0000
+Wed Feb 01 13:00:30 2006 -0500
+Wed Feb 01 13:00:30 2006 +0000
+Sun Jan 15 13:30:00 2006 +0500
+Sun Jan 15 13:30:00 2006 -0800
+Sat Jul 15 13:30:00 2006 +0500
+Sat Jul 15 13:30:00 2006 -0700
+Sun Jun 11 00:26:40 2006 -0400
+Sat Apr 15 13:30:00 2006 +0200
+Sat Apr 15 13:30:00 2006 +0000
+Wed Feb 01 13:00:30 2006 -0500
+Wed Feb 01 13:00:30 2006 +0000
+Sun Jan 15 13:30:00 2006 +0500
+Sun Jan 15 13:30:00 2006 -0800
+Sat Jul 15 13:30:00 2006 +0500
+Sat Jul 15 13:30:00 2006 -0700
+Sun Jun 11 00:26:40 2006 -0400
+Sat Apr 15 13:30:00 2006 +0200
+Sat Apr 15 13:30:00 2006 +0000
+Wed Feb 01 13:00:30 2006 -0500
+Wed Feb 01 13:00:30 2006 +0000
+Sun Jan 15 13:30:00 2006 +0500
+Sun Jan 15 13:30:00 2006 -0800
+Sat Jul 15 13:30:00 2006 +0500
+Sat Jul 15 13:30:00 2006 -0700
+Sun Jun 11 00:26:40 2006 -0400
+Sat Apr 15 13:30:00 2006 +0200
+Sat Apr 15 13:30:00 2006 +0000
+Wed Feb 01 13:00:30 2006 -0500
+Wed Feb 01 13:00:30 2006 +0000
+Sun Jan 15 13:30:00 2006 +0500
+Sun Jan 15 13:30:00 2006 -0800
+Sat Jul 15 13:30:00 2006 +0500
+Sat Jul 15 13:30:00 2006 -0700
+Sun Jun 11 00:26:40 2006 -0400
+Sat Apr 15 13:30:00 2006 +0200
+Sat Apr 15 13:30:00 2006 +0000
+Wed Feb 01 13:00:30 2006 -0500
+Wed Feb 01 13:00:30 2006 +0000
+Sun Jan 15 13:30:00 2006 +0500
+Sun Jan 15 13:30:00 2006 -0800
+Sat Jul 15 13:30:00 2006 +0500
+Sat Jul 15 13:30:00 2006 -0700
+Sun Jun 11 00:26:40 2006 -0400
+Sat Apr 15 13:30:00 2006 +0200
+Sat Apr 15 13:30:00 2006 +0000
+Wed Feb 01 13:00:30 2006 -0500
+Wed Feb 01 13:00:30 2006 +0000
+Sun Jan 15 13:30:00 2006 +0500
+Sun Jan 15 13:30:00 2006 -0800
+Sat Jul 15 13:30:00 2006 +0500
+Sat Jul 15 13:30:00 2006 -0700
+Sun Jun 11 00:26:40 2006 -0400
+Sat Apr 15 13:30:00 2006 +0200
+Sat Apr 15 13:30:00 2006 +0000
+Wed Feb 01 13:00:30 2006 -0500
+Wed Feb 01 13:00:30 2006 +0000
-------------- next part --------------
A non-text attachment was scrubbed...
Name: date-formats-with-space.diff
Type: application/octet-stream
Size: 6025 bytes
Desc: not available
Url : http://selenic.com/pipermail/mercurial/attachments/20090402/478ab8c3/attachment.obj
More information about the Mercurial
mailing list