hgext.mq/patchbomb not usable for submitting patches to lkml

Andrea Arcangeli andrea at qumranet.com
Thu May 15 11:36:42 CDT 2008


On Thu, May 15, 2008 at 04:49:41PM +0200, Andrea Arcangeli wrote:
> Let me know if this change is possible otherwise I'll have to consider
> if it's simpler to do it myself or I'll have change development

While looking into doing it myself, I seem to have found a workaround
if I replicate the Form with a space after Subject.

If I structure the header of the patch like this:

--------
From: Andrea Arcangeli <andrea at qumranet.com>
Subject: list_del_init_rcu

From: Andrea Arcangeli <andrea at qumranet.com>

Introduces list_del_init_rcu and documents it (fixes a comment for
list_del_rcu too).

Signed-off-by: Andrea Arcangeli <andrea at qumranet.com>
---

diff --git a/include/linux/list.h b/include/linux/list.h
[..]
-----

It generates this email:

-----
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: [PATCH] list_del_init_rcu
X-Mercurial-Node: 42178c0ecf7832a23f43310187c50468b91bb119
Message-Id: <42178c0ecf7832a23f43.1210869028 at duo.random>
Date: Thu, 15 May 2008 18:30:28 +0200
From: Andrea Arcangeli <andrea at qumranet.com>
To: andrea

From: Andrea Arcangeli <andrea at qumranet.com>

Introduces list_del_init_rcu and documents it (fixes a comment for
list_del_rcu too).

Signed-off-by: Andrea Arcangeli <andrea at qumranet.com>
---

diff -r 7ff725a068b0 -r 42178c0ecf78 include/linux/list.h
--- a/include/linux/list.h      Tue May 13 11:24:51 2008 -0700
+++ b/include/linux/list.h      Thu May 15 18:25:31 2008 +0200
@@ -747,7 +747,7 @@ static inline void hlist_del(struct hlis
-------

This seems ok finally with the duplicated From plus --plain passed to
the email command.

So I'll use this trick, until there's a proper git header format
supported by patchbomb. The proper git header format shouldn't require
me to add a 'From' only if it differs from the default User. Other
parts needs fixing like for example diffstat, which must go at least
after '---' and '---' should also automatically added if it isn't
already present and diffstat should go at the end if there's more text
after '---'. See SubmittingPatches for more details. Quoting below the
relevant part:

--------
The canonical patch subject line is:

    Subject: [PATCH 001/123] subsystem: summary phrase

The canonical patch message body contains the following:

  - A "from" line specifying the patch author.

  - An empty line.

  - The body of the explanation, which will be copied to the
    permanent changelog to describe this patch.

  - The "Signed-off-by:" lines, described above, which will
    also go in the changelog.

  - A marker line containing simply "---".

  - Any additional comments not suitable for the changelog.

  - The actual patch (diff output).

[..]
The "from" line must be the very first line in the message body,
and has the form:

        From: Original Author <author at example.com>
[..]
One good use for the additional comments after the "---" marker is for
a diffstat, to show what files have changed, and the number of
inserted
[..]


More information about the Mercurial mailing list