qrebase extension

Gregory Collins greg at maptuit.com
Tue May 6 09:55:51 CDT 2008


Gilles Moris <gilles.moris at free.fr> writes:

> Here am I again with the qrebase command but this time bundled as an
> extension. This should be much easier to maintain and to make it work
> with different versions of mercurial.

This is really great, thank you. Even a partial implementation of this
command is a huge improvement.

The implementation makes me a little nervous; particularly here:

    # rm -rf patches.N
    shutil.rmtree(newpath)
    # go to the previous patch level
    if curpatch:
        ui.write(_("\nPushing to %s patch:\n") % (curpatch))
        ret = q.push(repo, curpatch, None, None, None)
    # cancel any rollback as it does not make sense for a complex command
    q.removeundo(repo)

If something were to go wrong with the merge this has the potential for
losing work. In my local copy I'm going to do something like:

    ui.write(_("\nBackup queue saved to %s\n") % newpath)

instead. Backup behaviour should perhaps be a configuration option?

G.


More information about the Mercurial mailing list