AW: [PATCH 2 of 2] tests: remove glob lines which unnecessary match / for \ on windows

Matt Mackall mpm at selenic.com
Tue Feb 26 12:01:19 CST 2013


On Tue, 2013-02-26 at 09:42 +0100, Simon He. wrote:
> Having a check code recipe sounds good, but I have no idea how this could be done.
> I do not know of any rule when an "os path" and when a "hg path" is printed.

$ grep 'pulling from .TESTTMP/' *.t
test-blackbox.t:  pulling from $TESTTMP/blackboxtest   <- FAILED
test-bookmarks-pushpull.t:  pulling from $TESTTMP/a (glob)
test-issue1502.t:  pulling from $TESTTMP/foo (glob)
test-issue1502.t:  pulling from $TESTTMP/foo (glob)
test-issue1802.t:  pulling from $TESTTMP/unix-repo
test-largefiles.t:  pulling from $TESTTMP/a (glob)
test-largefiles.t:  pulling from $TESTTMP/b (glob)
test-obsolete-checkheads.t:  pulling from $TESTTMP/remote (glob)
test-pull-r.t:  pulling from $TESTTMP/repo2 (glob)
test-rebase-pull.t:  pulling from $TESTTMP/a (glob)
test-rebase-pull.t:  pulling from $TESTTMP/a (glob)
test-rebase-pull.t:  pulling from $TESTTMP/a (glob)
test-rebase-pull.t:  pulling from $TESTTMP/a (glob)
test-rebase-pull.t:  pulling from $TESTTMP/a (glob)
test-rebase-pull.t:  pulling from $TESTTMP/a (glob)
test-subrepo-git.t:  pulling from $TESTTMP/t (glob)
test-subrepo.t:  pulling from $TESTTMP/t (glob)

This suggests the rule: "if it starts with '  pulling from $TESTTMP/',
it better end with (glob)".

The great bulk of the places where we use '\' on Windows can be covered
by maybe a dozen patterns.

-- 
Mathematics is the supreme nostalgia of our time.




More information about the Mercurial-devel mailing list