[PATCH] char: Nano 7240 watchdog driver

[Randy Dunlap]

On Sat, 6 Oct 2007 00:02:29 -0400 Dave Jones wrote:

> On Sat, Oct 06, 2007 at 01:10:23PM +1000, Gilles GIGAN wrote:
>  > Hi everyone,
>  > I thought I d submit this patch here first, to see if I m doing the right
>  > thing. I do also have a couple of questions:
>  > Below is the email I d like to send to the LKML for inclusion in the kernel.
>  > - Is is appropriately formatted ? (I tried following the guidelines in
>  > SubmittingPatches as closely as possible)
> 
> Unfortunatly gmail mangled it. It's word-wrapped and white-space damaged
> so will never apply.  Maybe there's some options in the gmail UI you can
> change to make this not happen.  Test it by sending the patch to
> yourself first, and see if you can get it to apply with patch(1).

I've never heard of anyone successfully using the gmail GUI
for sending patches (other than by using attachments).

gmail also split some long lines for you at places that make
the patch mangled/broken.

>  > - is the patch correctly generated ? Are the changes to Kconfig and Makefile

The email includes html.  That's a "don't do that."


>  > to be included in the patch (like I did) ?
>  > - Is the email title OK ? (not really sure what subsystem I should use:
>  > "char" , "watchdog", "device drivers", ... ?)
> 
> 'watchdog' sounds sane. Remember to Cc the watchdog maintainer too
> Wim Van Sebroeck <wim at iguana.be>  (He may have more specific comments).

Yes, e.g.:  watchdog: add Nano 7240 driver


+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License
+ * as published by the Free Software Foundation; either version
+ * 2 of the License, or (at your option) any later version.

Wasn't there a decision that the kernel is only GPL v2 (modified)?

---
~Randy