On 3/31/06, Alexis S. L. Carvalho <mercurial-bugs@selenic.com> wrote:
>
> Two questions about the changes to the commit function:
>
> - With these changes, the precommit hook will run while holding the wlock.
>   Is that a problem?

I don't think it matters, the user probably don't want the working
copy to be modified (eg update/adding/removing/...) in the precommit
hook.
>
> - Should the wlock be passed to the changes function?
>
It should if possible, I'll correct it if the patch is ok.

thanks,

Benoit