Issue953

Title svn converter: bad handling of a corner case tag
Priority bug Status resolved
Superseder Nosy List ThomasAH, djc, edgomez, mpm, pmezard
Assigned To Topics convert, svn

Created on 2008-01-30.00:42:34 by edgomez, last changed 2008-04-13.11:59:29 by djc.

Messages
msg5889 (view) Author: djc Date: 2008-04-13.11:59:28
In main, resolving.
msg5748 (view) Author: pmezard Date: 2008-03-29.16:33:44
Should be fixed in 5efd447a9b8d.

> But 0.7->v0.7 should really be handled as deleting the old tag and creating a
new one.

I skipped that because convert extension does not currently work like that, it
updates the tags after the conversion process, not when they are created. Right
now, the tags directory is scanned backward and renaming followed, deleted tags
are still preserved.
msg5028 (view) Author: ThomasAH Date: 2008-01-30.09:06:43
I would not consider "commit in the tag itself, after a copy" (0.6.1) as
complete abuse, just as creating an unnamed branch and moving the tag to this
branch's head.

But 0.7->v0.7 should really be handled as deleting the old tag and creating a
new one.
msg5026 (view) Author: mpm Date: 2008-01-30.00:45:17
Updating subject
msg5025 (view) Author: edgomez Date: 2008-01-30.00:42:29
Suppose we tag the trunk as 0.7, and we realize the 0.7 name doesn't follow the
tag name policy vX.Y. For repairing that, a svn user will use 'svn move' to
delete+copy the tag.

That corner case is not handled well by the convert code because when
converting, it sees the v0.1 (rev x) as a copy from a previous revision that
convert will never deal with (the tag commit that really copies the trunk tree
to the tags directory).

A real SVN repo with this corner case exists for real:
https://rawstudio.org/svn/rawstudio/

See tag 0.7 that became v0.7

Tag 0.6.1 is really not the same story as i would consider it as subversion copy
feature abuse (commit in the tag itself, after a copy).

The solution to this problem would be to recurse copy_from until the revision is
actually known by convert or reaches rev 0.
History
Date User Action Args
2008-04-13 11:59:29djcsetstatus: testing -> resolved
nosy: + djc
messages: + msg5889
2008-03-29 16:33:45pmezardsetstatus: chatting -> testing
nosy: + pmezard
messages: + msg5748
2008-01-30 09:06:43ThomasAHsetnosy: + ThomasAH
messages: + msg5028
2008-01-30 00:45:20mpmsetstatus: unread -> chatting
nosy: + mpm
messages: + msg5026
title: bad handling of a corner case tag -> svn converter: bad handling of a corner case tag
2008-01-30 00:42:34edgomezcreate