Issue937

Title Error details from failed push hook not displayed to HTTP client
Priority bug Status resolved
Superseder Nosy List jglick, pmezard
Assigned To Topics http_proto

Created on 2008-01-19.18:14:07 by jglick, last changed 2008-03-17.07:25:32 by pmezard.

Messages
msg5625 (view) Author: pmezard Date: 2008-03-17.07:25:30
Supplied fix in crew and main as be76e54570f0
msg4924 (view) Author: jglick Date: 2008-01-19.18:14:07
If a repository on a server has configured some pretxnchangegroup hook which
displays an error message when it fails (e.g. hgext.win32text.forbidcrlf), and
this repository is accessed over HTTPS from a client (via hgwebdir.cgi), the
client hg program does not display the failure message when the push is
rejected. It only gives the name of the failed hook.

This is a usability problem; the developer attempting to push might not have
been made aware of the details of what pre-push hooks are installed and may be
surprised by the rejection and not know how to correct it. For example,
hgext.win32text.forbidcrlf when run as a pre-push hook prints a rather detailed
message about what is wrong and how it could be prevented in your local
repository in the future, but all this is lost when serving over HTTP(S).
History
Date User Action Args
2008-03-17 07:25:32pmezardsetstatus: unread -> resolved
nosy: pmezard, jglick
messages: + msg5625
2008-02-25 12:33:36pmezardsetnosy: + pmezard
2008-01-19 18:14:07jglickcreate