Issue896

Title using interhg (linking #nnn to our BTS) and gitweb messes up titles
Priority bug Status resolved
Superseder interhg produces invalid HTML in shortlog
View: 698
Nosy List ThomasAH, certik
Assigned To Topics

Created on 2007-12-25.22:20:43 by certik, last changed 2007-12-26.09:27:54 by ThomasAH.

Messages
msg4710 (view) Author: ThomasAH Date: 2007-12-26.09:27:54
Duplicate of issue698, resolving and setting superceder
msg4707 (view) Author: certik Date: 2007-12-25.23:10:22
OK, this is what I put into the .hg/hgrc to make it look quite reasonable:

[extensions]
interhg =

[interhg]
issues  = s!#(\d+)!<span style="text-decoration: underline;"
onclick="event.preventDefault(); document.location =
'http://www.sympy.org/issues/detail?id=\1';" onmouseover="window.status =
'http://www.sympy.org/issues/detail?id=\1';" onmouseout="window.status = '';"
title="View bug \1">\1</span>!

(but still it's confusing, that the mouse arrow doesn't change to "hand" to
indicate this is indeed a link)
msg4705 (view) Author: certik Date: 2007-12-25.22:49:02
This seems to be a duplicate of:

http://www.selenic.com/mercurial/bts/issue698

Let's get this fixed, it doesn't look very good on the web...
msg4703 (view) Author: certik Date: 2007-12-25.22:20:42
Hi,

we implemented linking things like #123 to our BTS using interhg, but we also
use gitweb. It works, but if the #123 occurs in the first line of the log,
like here:

http://hg.sympy.org/sympy/rev/ea69d4f982f4

you can see, that the title looks like this:

Make sympify("_a") work (
#496)

instead of this:

Make sympify("_a") work (#496)

and that's because it's HTML source code is:

<a class="title" href="/sympy/raw-rev/ea69d4f982f4">Make sympify(&quot;_a&quot;)
work (<a href="http://www.sympy.org/issues/detail?id=496">#496</a>) <span
class="logtags"></span></a>

so the two nested "<a>" tags mess up things. Should this be fixed in interhg,
or gitweb? My bet is in gitweb (to remove any <a> links from all titles)

Ondrej
History
Date User Action Args
2007-12-26 09:27:54ThomasAHsetstatus: chatting -> resolved
superseder: + interhg produces invalid HTML in shortlog
messages: + msg4710
nosy: + ThomasAH
2007-12-25 23:10:32certiksetmessages: - msg4706
2007-12-25 23:10:22certiksetmessages: + msg4707
2007-12-25 23:07:43certiksetmessages: + msg4706
2007-12-25 22:49:02certiksetstatus: unread -> chatting
messages: + msg4705
2007-12-25 22:20:43certikcreate