Issue1258

Title hgweb doesn't follow diff.git=1 option
Priority bug Status resolved
Superseder Nosy List ThomasAH, abuehl, djc, jglick, mathieu.clabaut, mpm, mzlamal
Assigned To djc Topics diff, hgweb

Created on 2008-08-12.09:37:11 by mzlamal, last changed 2008-11-04.07:43:49 by djc.

Messages
msg7840 (view) Author: djc Date: 2008-11-04.07:43:49
In main, resolving.
msg7828 (view) Author: djc Date: 2008-11-03.20:41:45
This is fixed in e74a9173c2d7, in crew.
msg7803 (view) Author: mpm Date: 2008-11-02.19:50:23
The fp interface keeps getting worked around, so yes, let's do that.
msg7767 (view) Author: djc Date: 2008-11-02.13:10:20
So hgweb's diff currently uses mdiff.unidiff(), which means it doesn't get all
the git-diff niceties from patch.diff(). patch.diff() wants a file-like object
to write to however, which doesn't map nicely to WSGI primitives. I think
patch.diff() could be implemented as a generator instead of writing to the
argument fp, which seems to me like a more potent API anyway. I guess
performance might be a concern. Would this be an acceptable change? (After this,
showing git diffs in hgweb should be a lot easier.)
msg7525 (view) Author: mpm Date: 2008-10-18.19:41:43
see issue1223
msg7517 (view) Author: mpm Date: 2008-10-18.19:20:19
I'm all for this, if it's not already working.
msg6754 (view) Author: djc Date: 2008-08-12.11:13:40
From hgweb_mod.py:456 and below (in crew-stable), it seems as if hgweb passes
the repo.ui to patch.diffopts and passes the diffopts to the diff functions...
msg6753 (view) Author: ThomasAH Date: 2008-08-12.10:47:12
Confirmed with hgweb and hg serve, and I think this could be useful.
msg6752 (view) Author: mzlamal Date: 2008-08-12.09:37:11
The hgweb interface doesn't show the diffs in GIT style if set in hgrc.
It is hard to track renames see http://hg.netbeans.org/core-main/rev/7feb73dd4871 
as an example.
History
Date User Action Args
2008-11-04 07:43:49djcsetstatus: testing -> resolved
nosy: mpm, ThomasAH, mathieu.clabaut, jglick, djc, abuehl, mzlamal
messages: + msg7840
2008-11-03 20:41:45djcsetstatus: chatting -> testing
nosy: mpm, ThomasAH, mathieu.clabaut, jglick, djc, abuehl, mzlamal
messages: + msg7828
2008-11-02 19:50:23mpmsetnosy: mpm, ThomasAH, mathieu.clabaut, jglick, djc, abuehl, mzlamal
messages: + msg7803
2008-11-02 13:10:23djcsetnosy: mpm, ThomasAH, mathieu.clabaut, jglick, djc, abuehl, mzlamal
messages: + msg7767
2008-10-18 19:41:43mpmsetnosy: mpm, ThomasAH, mathieu.clabaut, jglick, djc, abuehl, mzlamal
messages: + msg7525
2008-10-18 19:20:19mpmsetnosy: + mpm
messages: + msg7517
assignedto: djc
2008-08-12 11:13:40djcsetnosy: + djc
messages: + msg6754
2008-08-12 10:47:13ThomasAHsettopic: + hgweb, diff
nosy: + ThomasAH
status: unread -> chatting
messages: + msg6753
2008-08-12 10:07:06mathieu.clabautsetnosy: + mathieu.clabaut
2008-08-12 09:41:34abuehlsetnosy: + abuehl
2008-08-12 09:37:11mzlamalcreate