Issue1201

Title hg convert on CVS working copy produces Traceback
Priority bug Status chatting
Superseder Nosy List djc, frank, martinoconnor
Assigned To Topics convert

Created on 2008-06-25.14:42:46 by martinoconnor, last changed 2008-06-30.21:23:47 by martinoconnor.

Files
File name Uploaded Type Edit Remove
cvs-convert.patch martinoconnor, 2008-06-30.21:23:47 application/octet-stream
Messages
msg6415 (view) Author: martinoconnor Date: 2008-06-25.20:38:56
I have committed a patch to mercurial-devel mailing list
msg6411 (view) Author: frank Date: 2008-06-25.17:15:06
On Windows Python still manages to find a suitable expansion for ~.
This is the only occurrence of "HOME" in the Mercurial sources.
msg6410 (view) Author: martinoconnor Date: 2008-06-25.16:29:14
that solution only seems to make sense on a *nix system
would that translate to say a windows system?
msg6409 (view) Author: frank Date: 2008-06-25.16:22:42
cvs.py has
    pf = open(os.path.join(os.environ["HOME"], ".cvspass"))

which causes this. I think that should say
    pf = open(os.path.expanduser("~/.cvspass"))
msg6407 (view) Author: martinoconnor Date: 2008-06-25.14:42:45
** Mercurial Distributed SCM (version 1.0.1+20080525)
Traceback (most recent call last):
  File "hg", line 20, in <module>
  File "mercurial\dispatch.pyc", line 20, in run
  File "mercurial\dispatch.pyc", line 29, in dispatch
  File "mercurial\dispatch.pyc", line 45, in _runcatch
  File "mercurial\dispatch.pyc", line 364, in _dispatch
  File "mercurial\dispatch.pyc", line 417, in _runcommand
  File "mercurial\dispatch.pyc", line 373, in checkargs
  File "mercurial\dispatch.pyc", line 358, in <lambda>
  File "hgext\convert\__init__.pyc", line 127, in convert
  File "hgext\convert\convcmd.pyc", line 335, in convert
  File "hgext\convert\convcmd.pyc", line 50, in convertsource
  File "hgext\convert\cvs.pyc", line 32, in __init__
  File "hgext\convert\cvs.pyc", line 164, in _connect
  File "os.pyc", line 432, in __getitem__
KeyError: 'HOME'
History
Date User Action Args
2008-06-30 21:23:47martinoconnorsetfiles: + cvs-convert.patch
nosy: djc, frank, martinoconnor
2008-06-25 20:38:58martinoconnorsetnosy: djc, frank, martinoconnor
messages: + msg6415
2008-06-25 18:26:28djcsetnosy: + djc
2008-06-25 17:15:07franksetmessages: + msg6411
2008-06-25 16:29:14martinoconnorsetmessages: + msg6410
2008-06-25 16:22:43franksetstatus: unread -> chatting
nosy: + frank
messages: + msg6409
2008-06-25 14:42:46martinoconnorcreate