Issue1066

Title win32text cleverdecode mode in 1.0 does not handle PDF files well
Priority bug Status resolved
Superseder Nosy List blacktrash, bos, djc, jglick, pmezard
Assigned To Topics windows

Created on 2008-04-01.01:28:20 by jglick, last changed 2008-04-15.00:14:25 by bos.

Messages
msg5906 (view) Author: bos Date: 2008-04-15.00:14:25
Shouldn't be a problem.  util.binary now checks an entire string, not just the
first 4K.
msg5905 (view) Author: jglick Date: 2008-04-15.00:10:18
Unfortunately this got reverted again by Bryan's #4b2c266bf059.
msg5892 (view) Author: djc Date: 2008-04-13.12:02:16
In main, resolving.
msg5830 (view) Author: pmezard Date: 2008-04-04.21:20:19
> This should IMHO be backed out

Done in crew-stable and crew by 6ed371423d34, thanks.
msg5773 (view) Author: blacktrash Date: 2008-04-01.10:28:44
I asked about that when I submitted the patch ;)

However I believe the other cleanups should stay,
so no backout, just revert to previous behaviour:

http://www.selenic.com/pipermail/mercurial-devel/2008-April/005648.html
msg5769 (view) Author: jglick Date: 2008-04-01.01:28:18
changeset:   6247:7f4257b5cbfc
parent:      6242:a375ffc2aa1b
user:        Christian Ebert <blacktrash@gmx.net>
date:        Thu Mar 13 10:42:46 2008 +0100
summary:     win32text: use util.binary to detect \0

This should IMHO be backed out. See for example
usersguide/tutorials/j2ee-tut/fm/J2EE-NBTutorial.pdf in hg.netbeans.org/main as
of 397a011dde00; this should be treated as a binary file, and in Hg 0.9.5 it
was. It contains CRLF, and also NUL - but not in the first 4096 bytes. Therefore
checking out the file on a Windows box with the decode/encode hooks active
prints a warning. In this case can be worked around by running dos2unix on the
file, which seems to still make it viewable as PDF.
History
Date User Action Args
2008-04-15 00:14:25bossetstatus: chatting -> resolved
nosy: bos, blacktrash, pmezard, jglick, djc
messages: + msg5906
2008-04-15 00:10:18jglicksetstatus: resolved -> chatting
nosy: + bos
messages: + msg5905
2008-04-13 12:02:16djcsetstatus: testing -> resolved
nosy: + djc
messages: + msg5892
2008-04-04 21:20:19pmezardsetstatus: chatting -> testing
nosy: + pmezard
messages: + msg5830
2008-04-01 10:28:44blacktrashsetstatus: unread -> chatting
nosy: + blacktrash
messages: + msg5773
2008-04-01 01:28:20jglickcreate