Issue1000

Title merge.py ignores uncommitted copies
Priority bug Status chatting
Superseder Nosy List alexis, jcoomes, mpm
Assigned To alexis Topics merge, patch

Created on 2008-02-22.17:40:21 by alexis, last changed 2008-07-11.20:28:56 by jcoomes.

Files
File name Uploaded Type Edit Remove
working-dir-copies.patch alexis, 2008-02-22.17:40:21 text/plain
working-dir-copies2.patch.txt alexis, 2008-03-15.02:24:13 text/plain
working-dir-copies3.patch.txt jcoomes, 2008-07-11.20:28:52 text/plain
Messages
msg6497 (view) Author: jcoomes Date: 2008-07-11.20:28:52
I rebased the patch to 6766:e81d2bd66908 and attached as
working-dir-copies3.patch.txt (mostly trivial changes to the test output; kept
Alexis' name on it).  It passes the test suite on solaris, although the convert
tests were skipped because of missing sfw.

So it works for me, but I haven't tested it extensively.  Is there anything
that's known to be missing or incorrect?  I don't understand dirstate well
enough to make any judgement.  Would more testing help?
msg6346 (view) Author: mpm Date: 2008-06-18.21:28:43
Mostly fixed, degrading to bug?
msg5610 (view) Author: alexis Date: 2008-03-15.02:24:13
I'm attaching what I currently have.
msg5607 (view) Author: alexis Date: 2008-03-15.01:34:57
While writing a test for this, I noticed that that patch is not enough, since
it doesn't update the dirstate, and this is turning out to be quite a bit
more tricky than I expected.
msg5597 (view) Author: mpm Date: 2008-03-14.16:02:17
I've pulled this into main as it fixes another problem I ran into.
msg5505 (view) Author: mpm Date: 2008-03-10.06:23:39
Patch looks fine.
msg5357 (view) Author: jcoomes Date: 2008-02-22.18:17:38
The patch works for the simple test cases I have; thanks.

The problem resulted in a lot of tedium when trying to reorg many files in a repo,
and I have more rounds of this kind of thing planned.  So I'm going to bump the
priority; adjust if you disagree.
msg5354 (view) Author: alexis Date: 2008-02-22.17:40:21
As mentioned in msg5349 in issue988, "hg update" doesn't take into account
uncommitted copies.  To reproduce:

----------------
hg init repo
cd repo

touch foo
hg ci -Am 'add foo'

echo >> foo
hg ci -m 'change foo'

hg up -C 0
hg mv foo bar
HGMERGE=false thg --debug -y update
--------------------------

A similar problem happens with hg merge --force.

I'm attaching a possible patch.
History
Date User Action Args
2008-07-11 20:28:56jcoomessetfiles: + working-dir-copies3.patch.txt
nosy: mpm, alexis, jcoomes
messages: + msg6497
2008-06-18 21:28:43mpmsetpriority: urgent -> bug
nosy: mpm, alexis, jcoomes
messages: + msg6346
2008-03-15 02:24:15alexissetfiles: + working-dir-copies2.patch.txt
nosy: mpm, alexis, jcoomes
messages: + msg5610
2008-03-15 01:34:58alexissetnosy: mpm, alexis, jcoomes
messages: + msg5607
2008-03-14 16:02:19mpmsetnosy: mpm, alexis, jcoomes
messages: + msg5597
2008-03-10 06:23:39mpmsetnosy: mpm, alexis, jcoomes
messages: + msg5505
assignedto: alexis
2008-02-22 18:17:40jcoomessetpriority: bug -> urgent
nosy: mpm, alexis, jcoomes
status: unread -> chatting
messages: + msg5357
2008-02-22 17:40:22alexiscreate